Say which line a C++ program writes, because we told a consumer the wrong one - #23
Merged
Merged
Conversation
…rong one⚠️ ⚠️ README's first code block is for a C program, and a C++ program names `openkal-llvm-runtime' INSTEAD. Naming both is not redundancy --- that package pins this one exactly, a version requirement here does not float up, and a program that names both gets neither: error: dependency 'mcpplibs.openkal-musl' has irreconcilable versions: '0.10.0' requested by '<the program>' '0.9.0' requested by 'mcpplibs.openkal-llvm-runtime@0.5.0' ⭐ RECORDED BECAUSE WE GOT IT WRONG OURSELVES. The consumer who reported openkal-linux#13 builds C++ --- their own reports name libc++abi --- and the 0.10.0 announcement told them to change openkal-musl = "0.10.0" which for their build does not select the new C library and does not select the old one either. It does not resolve. The correction is posted on that issue and `openkal-llvm-runtime' 0.6.0 is what makes the right line exist. ⇒ A table, so that the next consumer answers this without asking and the next release has an obvious place to be recorded.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
openkal-llvm-runtimeinstead — and naming both is an error rather than aredundancy, because that package pins this one exactly and a version
requirement here does not float up:
⭐ Recorded because we got it wrong ourselves. The consumer who reported
openkal-linux#13 builds C++ — their own crash reports name libc++abi — and the
0.10.0 announcement told them to write
openkal-musl = "0.10.0", which for theirbuild selects neither the new C library nor the old one. It does not resolve.
A version table is added so the next consumer answers this without asking, and so
the next release has an obvious place to be recorded.
Documentation only — no source, no criteria, no version change.