0.9.7 --- the package states [package] standard in place of the unread [build] cxx_standard - #22
Open
Sunrisepeak wants to merge 1 commit into
Open
Sunrisepeak wants to merge 1 commit into
Sunrisepeak wants to merge 1 commit into
Conversation
… the unread [build] cxx_standard
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
States the language level of this package's own sources in the key the engine reads (mcpp-community/mcpp#641, item 2; mcpp-community/mcpp#644).
The defect. The manifest wrote
[build] cxx_standard = "c++23". No mcpp release has read that key: at the package's own root the engine prints[build] has unsupported key 'cxx_standard' (ignored), and as a dependency it says nothing. The package therefore stated no standard, and its sources were compiled at whatever level the consuming graph used.Changes:
[package] standard = "c++23"replaces the unread key; version 0.9.7.standardas it always has (not applied), and the package's own root is c++23 either way, so nothing changes for the engines this repository's CI pins.Measured. This branch passed the whole workflow against the engine branch of mcpp#644 (
mcpp_ref=feat/641-642, run 34895002497): the runtime job and the four host jobs, Linux, macOS and Windows.