0.9.4 --- follow openkal-musl 0.13.3 - #19
Merged
Merged
Conversation
Carries openkal-musl 0.13.3: a detached thread that ended stopped the program on macOS, because musl's 256-byte shared exit stack was overrun by the port's system call path; and openkal-windows 0.7.3, whose channel ends reach only the program they are placed in and whose started programs receive their arguments and directory as given. A version requirement here is exact, so consumers reach these only through this release. examples/cxx now also detaches a std::thread and waits for it to end, and the host jobs require it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Carries openkal-musl 0.13.3 (mcpplibs/openkal-musl#32), which fixes two defects every C++ consumer of this package is exposed to. This package's requirement on openkal-musl is exact, so consumers reach them only through this release.
std::threadthat ended stopped the program on macOS. musl's__unmapselfmoved to a 256-byte stack shared by every exiting thread, and openkal-musl's path for the calls that end the thread needed far more; the overflow overwrote the context table the exit then read. Found through lsp-mcpp, whose server crashed on macos-14 as soon as its input reader thread ended.\\?\form.examples/cxxnow also detaches astd::threadand waits for it to end, and the host jobs require it:ok: a detached thread runs and ends.Measured with lsp-mcpp over this tree, openkal-musl 0.13.3 and openkal-windows 0.7.3, cross-built for
x86_64-windows-gnuand run under Wine: all 15 unit-test programs pass in the dev profile, and in the release profile the process, task, file system and server tests and theinferredconformance fixture pass.0.9.4.