Commit f369594
committed
ci: name the encoding the check reads its sources in
Python opens a file with the platform's default encoding, which on the Windows
runner is cp1252, and these sources are UTF-8:
UnicodeDecodeError: 'charmap' codec can't decode byte 0x90 in position 90
A check that reads source files must say what they are encoded in, or it reports
on the runner's locale rather than on the sources. The byte it stopped at is in a
comment marker, so the check would have passed on a repository whose comments
happened to be ASCII and failed on this one --- which is the least useful place
for a difference to appear.
Both reads name utf-8. Rehearsed locally under cp1252: 42 declared, 49 exported,
none missing.1 parent 6fda245 commit f369594
1 file changed
Lines changed: 9 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
182 | 182 | | |
183 | 183 | | |
184 | 184 | | |
| 185 | + | |
| 186 | + | |
| 187 | + | |
| 188 | + | |
| 189 | + | |
| 190 | + | |
| 191 | + | |
185 | 192 | | |
186 | | - | |
| 193 | + | |
187 | 194 | | |
188 | 195 | | |
189 | | - | |
| 196 | + | |
190 | 197 | | |
191 | 198 | | |
192 | 199 | | |
| |||
0 commit comments