Skip to content

Commit 971af30

Browse files
committed
examples: name openkal the way this repository does
mcpp refuses a graph in which one package reaches a dependency by version and another by git: dependency 'mcpplibs.openkal' is requested as both a version dep (by 'hello') and a git dep (by 'mcpplibs.openkal-<this>@path'). Pick one. That is the right refusal --- two forms can name two different trees --- and it means an example inside a repository must follow that repository's own declaration while a change spanning repositories is in flight. The example named a released version while the package beside it followed a branch.
1 parent b07c77b commit 971af30

1 file changed

Lines changed: 11 additions & 1 deletion

File tree

examples/hello/mcpp.toml

Lines changed: 11 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,5 +13,15 @@ runner = ["qemu-system-riscv64", "-machine", "virt", "-nographic",
1313
"-no-reboot", "-bios", "default", "-kernel"]
1414

1515
[dependencies]
16-
openkal = "0.7.0"
16+
# ⚠️ THE FORM MUST MATCH THE ONE THE IMPLEMENTATION USES, not merely the
17+
# version. mcpp refuses a graph in which one package reaches a dependency by
18+
# version and another by git:
19+
#
20+
# dependency 'mcpplibs.openkal' is requested as both a version dep
21+
# (by 'hello') and a git dep (by 'mcpplibs.openkal-opensbi@path').
22+
#
23+
# That is the right refusal --- two forms can name two different trees --- and
24+
# it means an example inside a repository follows that repository's own
25+
# declaration while a change is in flight.
26+
openkal = { git = "https://github.com/mcpplibs/openkal", branch = "feat/openkal-0.8" }
1727
openkal-opensbi = { path = "../.." }

0 commit comments

Comments
 (0)