Commit 9ea3271
authored
fix(mysql-connector-cpp): a CN mirror, and a success path that says so (#389)
TWO SMALL THINGS, both found while this package kept turning up in the
middle of something else.
CN MIRROR
The url was a plain upstream string, which docs/cn-mirror.md describes as
the fallback for when nobody has `mcpp-res` write access -- CN users reach
GitHub directly and wait. This package sits on the path of anything that
touches the graphics or database members, and a 4.8 MB tarball with no
mirror was a recurring tax on exactly the runs where something else was
being diagnosed.
`mcpp-res/mysql-connector-cpp@26.7.0` now carries the same bytes:
CN http=200 size=4792083
GLOBAL sha b2299862eefc33fd71c0aac68328305671805fc955e6bd2578ef205c10f98550
CN sha b2299862eefc33fd71c0aac68328305671805fc955e6bd2578ef205c10f98550
Same sha as the descriptor already declared, so no version's hash moves.
`return true` ON THE SUCCESS PATH
`install()` wraps its work in a pcall and returns whatever that yields.
Every failure path says `return false`; the success path ended on an
`io.writefile` and yielded `nil`. So a WORKING install has been logging
install() result=nil
all along. In a hook log that is otherwise a list of failures, that reads
like one — and it did: during the huxerui work it was taken for the cause
of a failure whose real origin was an mcpp scanner regression three layers
away. The value was never wrong; it just never said it was right.1 parent 409a433 commit 9ea3271
1 file changed
Lines changed: 16 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
17 | 17 | | |
18 | 18 | | |
19 | 19 | | |
20 | | - | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
21 | 24 | | |
22 | 25 | | |
23 | 26 | | |
| |||
28 | 31 | | |
29 | 32 | | |
30 | 33 | | |
31 | | - | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
32 | 38 | | |
33 | 39 | | |
34 | 40 | | |
| |||
318 | 324 | | |
319 | 325 | | |
320 | 326 | | |
| 327 | + | |
| 328 | + | |
| 329 | + | |
| 330 | + | |
| 331 | + | |
| 332 | + | |
| 333 | + | |
| 334 | + | |
321 | 335 | | |
322 | 336 | | |
323 | 337 | | |
| |||
0 commit comments