ci: 233 runs on three platforms, so three workflows need the pinned trees

The new criterion fired on macOS and was right to. `submodules: recursive`
went onto the Linux e2e shards only, and `233_bench_matrix.sh` runs in every
job that invokes the whole suite -- of which there are three, not one. That is
the same shape as the defect it was added for: a check reasoned about against
one job and applied to all of them.

Enumerated rather than guessed this time. The three unfiltered
`bash tests/e2e/run_all.sh` jobs are ci-linux-e2e, ci-macos-e2e and
ci-windows-e2e, and all three now check the trees out.
ci-windows-msvc-xlings sets `E2E_ONLY: '239_*.sh'`, so 233 does not run
there; ci-linux-e2e's baremetal job and openkal-cross name their tests
directly.

The failure now says what to do rather than asserting that this job already
asks for the submodules -- which would be false for exactly the job that
needs to be told.

Author: speak-agent

.github/workflows/ci-macos-e2e.yml

@@ -28,7 +28,14 @@ jobs:
     # NOTE: no MCPP_VERBOSE — the e2e suite asserts mcpp's default quiet
     # output (tests 48/53).
     steps:
+      # `submodules: recursive` so tests/e2e/233_bench_matrix.sh can check that
+      # each `hub`/`body` in bench/matrix.json exists in the tree it names --
+      # the check reads "submodule not initialised" without them and reports
+      # nothing, which is how a stale hub path survived (#599). Under 10 MB of
+      # source across the three pins, and nothing here builds them.
       - uses: actions/checkout@v4
+        with:
+          submodules: recursive
       - uses: ./.github/actions/setup-macos-llvm
 
       - name: Build mcpp from source (self-host)

.github/workflows/ci-windows-e2e.yml

@@ -36,7 +36,14 @@ jobs:
       # assert mcpp's DEFAULT (quiet) output — e.g. 48_build_error_output and
       # 53_namespaced_cache_label — which forced verbose would break.
     steps:
+      # `submodules: recursive` so tests/e2e/233_bench_matrix.sh can check that
+      # each `hub`/`body` in bench/matrix.json exists in the tree it names --
+      # the check reads "submodule not initialised" without them and reports
+      # nothing, which is how a stale hub path survived (#599). Under 10 MB of
+      # source across the three pins, and nothing here builds them.
       - uses: actions/checkout@v4
+        with:
+          submodules: recursive
       - uses: ./.github/actions/bootstrap-mcpp
 
       - name: Build mcpp from source (self-host)

tests/e2e/233_bench_matrix.sh

@@ -356,8 +356,13 @@ if uninit:
            f"— submodule(s) not checked out")
     if os.environ.get("CI"):
         print("FAIL: bench/matrix.json")
-        print(f"  {msg}; this job asks for `submodules: recursive`, so the "
-              f"check that catches a stale hub did not run")
+        print(f"  {msg} -- so the check that catches a stale `hub` did not run.")
+        print("  A job that runs the whole e2e suite needs the pinned trees: add")
+        print("    - uses: actions/checkout@v4")
+        print("      with:")
+        print("        submodules: recursive")
+        print("  to this job's checkout. Under 10 MB across the three pins, and")
+        print("  nothing here builds them.")
         raise SystemExit(1)
     print(f"  NOTE: {msg} (`git submodule update --init`)")
 PY