Commit 71d815f
committed
fix(e2e): the leg-selection grep assumed forward slashes
256's `check` extracted the selected leg with
`grep -o "dist/mathkit-0.1.0/lib/[A-Za-z0-9_-]*"`. A native mcpp.exe writes
NATIVE separators into build.ninja, so on Windows that matched nothing at all and
the test reported
native saw more than one leg:
(empty)
— i.e. a count of zero, printed as "more than one", over an empty list. It reads
like a packaging bug on the one platform where nothing else could confirm it, and
it is a grep bug.
Anchored on the package name instead, with `[\\/]` for either separator, and the
failure now prints the count and the package's own lines from build.ninja so the
next reader is not guessing. 245 carries the same helper — it only runs on Linux,
but leaving the fragile version there invites the next test to copy it — and
passes locally with it, which is what validates the pattern on `/`.1 parent 3d104ca commit 71d815f
2 files changed
Lines changed: 22 additions & 6 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
101 | 101 | | |
102 | 102 | | |
103 | 103 | | |
104 | | - | |
| 104 | + | |
| 105 | + | |
| 106 | + | |
| 107 | + | |
| 108 | + | |
| 109 | + | |
105 | 110 | | |
106 | | - | |
107 | | - | |
| 111 | + | |
| 112 | + | |
| 113 | + | |
108 | 114 | | |
109 | 115 | | |
110 | 116 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
125 | 125 | | |
126 | 126 | | |
127 | 127 | | |
128 | | - | |
| 128 | + | |
| 129 | + | |
| 130 | + | |
| 131 | + | |
| 132 | + | |
| 133 | + | |
| 134 | + | |
129 | 135 | | |
130 | | - | |
131 | | - | |
| 136 | + | |
| 137 | + | |
| 138 | + | |
| 139 | + | |
| 140 | + | |
| 141 | + | |
132 | 142 | | |
133 | 143 | | |
134 | 144 | | |
| |||
0 commit comments