Commit 6f75688
committed
docs(plan): the validation item gets a criterion and a slot, and that criterion was wrong
Review pass over the whole document. Three findings, one of which is a defect
in a criterion rather than an omission.
OMISSION -- the validation experiment had neither a criterion nor a stage. It
was described at length in section 10 and then appeared in neither the criteria
table nor the staging table, so nothing tied it to the rest of the plan. Added
as C9 and as a staging row with 13.1 explaining where it sits.
DEFECT -- C9's decisive criterion, "git diff src/ is empty", cannot tell two
failures apart:
* the diff carries an Ascend-specific identifier -> the claim is refuted
* the diff is a general capability like exports -> the engine is merely
missing general infrastructure, which is what sections 2-6 exist to add
Both read the same, so running it before the general gaps land would report the
second as the first. Replaced by two levels: the primary criterion is that
test_core_vendor_probes.cpp stays green after the port, which judges by
property rather than by whether anything changed and therefore needs no
precondition; "git diff src/ empty" is kept as a stricter additional statement,
valid only after stages one to three.
That also unblocks running the experiment early: the primary criterion works at
any time, and an early run may surface a fifth general gap, which is cheaper
than discovering it after three stages of engine work.
ORPHAN -- kind = "device" appeared once, in the attribution table, with no
criterion and no stage. It sits in a cross box: engine-side by test 2, but
domain by the section 0.1 admission line, because it talks about accel. Two
rulers, and they cross. Stated explicitly and scoped to docs/20 rather than
left ambiguous.
Also marked the superseded half of revision two in the change record, so a
reader scanning the log does not take an overturned conclusion as current.1 parent d201de1 commit 6f75688
1 file changed
Lines changed: 52 additions & 9 deletions
Lines changed: 52 additions & 9 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
343 | 343 | | |
344 | 344 | | |
345 | 345 | | |
| 346 | + | |
| 347 | + | |
| 348 | + | |
| 349 | + | |
| 350 | + | |
346 | 351 | | |
347 | 352 | | |
348 | 353 | | |
| |||
353 | 358 | | |
354 | 359 | | |
355 | 360 | | |
356 | | - | |
| 361 | + | |
357 | 362 | | |
358 | 363 | | |
359 | 364 | | |
| |||
625 | 630 | | |
626 | 631 | | |
627 | 632 | | |
628 | | - | |
| 633 | + | |
| 634 | + | |
| 635 | + | |
| 636 | + | |
| 637 | + | |
| 638 | + | |
| 639 | + | |
| 640 | + | |
| 641 | + | |
| 642 | + | |
629 | 643 | | |
630 | | - | |
631 | | - | |
632 | | - | |
633 | | - | |
| 644 | + | |
| 645 | + | |
| 646 | + | |
| 647 | + | |
| 648 | + | |
| 649 | + | |
634 | 650 | | |
635 | | - | |
636 | | - | |
| 651 | + | |
| 652 | + | |
| 653 | + | |
| 654 | + | |
| 655 | + | |
| 656 | + | |
| 657 | + | |
| 658 | + | |
| 659 | + | |
| 660 | + | |
| 661 | + | |
637 | 662 | | |
638 | 663 | | |
639 | 664 | | |
| |||
668 | 693 | | |
669 | 694 | | |
670 | 695 | | |
| 696 | + | |
671 | 697 | | |
672 | 698 | | |
673 | 699 | | |
| |||
688 | 714 | | |
689 | 715 | | |
690 | 716 | | |
| 717 | + | |
691 | 718 | | |
692 | 719 | | |
693 | 720 | | |
694 | 721 | | |
| 722 | + | |
| 723 | + | |
| 724 | + | |
| 725 | + | |
| 726 | + | |
| 727 | + | |
| 728 | + | |
| 729 | + | |
| 730 | + | |
| 731 | + | |
| 732 | + | |
| 733 | + | |
| 734 | + | |
| 735 | + | |
| 736 | + | |
695 | 737 | | |
696 | 738 | | |
697 | 739 | | |
698 | 740 | | |
699 | 741 | | |
700 | 742 | | |
701 | | - | |
| 743 | + | |
702 | 744 | | |
| 745 | + | |
703 | 746 | | |
0 commit comments