Skip to content

Commit 1db0816

Browse files
committed
ci(release): fix two ecosystem-publish pipeline gaps found on the 0.0.83 train
1. Index bump never worked from the release runner: version-check.py defaults --workspace to GITHUB_WORKSPACE, which inside the RELEASE repo's runner is the release repo — not the freshly-cloned index ('error: …/pkgs not found'). Pass --workspace . explicitly. 2. ci-fresh-install's 'on: release published' hook has never fired: the release is created with GITHUB_TOKEN and GitHub suppresses workflow triggers from GITHUB_TOKEN-generated events. Dispatch it explicitly with a PAT after publishing (best-effort; the daily schedule remains the fallback).
1 parent b0747c9 commit 1db0816

2 files changed

Lines changed: 18 additions & 1 deletion

File tree

.github/tools/bump_index.sh

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,11 @@ git config user.name "xlings-ci"
3838
git checkout -q -B "$BRANCH"
3939

4040
info "version-check.py --apply --only $PROJ"
41-
python3 .github/scripts/version-check.py --apply --only "$PROJ" > "$WORK/report.json" || {
41+
# --workspace: version-check.py defaults its repo root to GITHUB_WORKSPACE,
42+
# which inside the RELEASE repo's runner is the release repo — not this
43+
# freshly-cloned index. Point it at the clone explicitly ("error: …/pkgs not
44+
# found" was this default kicking in; observed on the 0.0.83 release).
45+
python3 .github/scripts/version-check.py --workspace . --apply --only "$PROJ" > "$WORK/report.json" || {
4246
echo "[bump] version-check failed:" >&2; cat "$WORK/report.json" >&2 2>/dev/null || true; exit 1;
4347
}
4448

.github/workflows/release.yml

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -737,3 +737,16 @@ jobs:
737737
chmod +x .github/tools/bump_index.sh
738738
bash .github/tools/bump_index.sh mcpp "${{ steps.version.outputs.version }}" \
739739
|| echo "index bump reported issues (non-blocking)"
740+
741+
# ci-fresh-install declares `on: release published`, but the release is
742+
# created with GITHUB_TOKEN and GitHub suppresses workflow triggers from
743+
# GITHUB_TOKEN-generated events — so that hook has never fired (only the
744+
# daily schedule ran it). Dispatch it explicitly with a PAT; best-effort
745+
# (the schedule remains the fallback).
746+
- name: Dispatch fresh-install verification
747+
if: ${{ env.XIM_PKGINDEX_TOKEN != '' }}
748+
env:
749+
GH_TOKEN: ${{ secrets.XIM_PKGINDEX_TOKEN }}
750+
run: |
751+
gh workflow run ci-fresh-install.yml -R "${{ github.repository }}" --ref main \
752+
|| echo "fresh-install dispatch failed (non-blocking; daily schedule covers it)"

0 commit comments

Comments
 (0)